This repository was archived by the owner on Dec 1, 2020. It is now read-only.
Fixes to esriLoader to enable passing an array of strings to it#54
Merged
tomwayson merged 2 commits intoEsri:masterfrom Jul 28, 2015
Merged
Fixes to esriLoader to enable passing an array of strings to it#54tomwayson merged 2 commits intoEsri:masterfrom
tomwayson merged 2 commits intoEsri:masterfrom
Conversation
The current implementation allows an array of strings to be passed to the loader, but $q Resolves only support 1 parameter. Therefore, in your .then() function you would only ever get the first module in your list. The loader will now take a callback function that will be passed all of the requested modules. The original implementation is also intact so as not to break an application if someone decides to update to this version.
Contributor
Author
|
Sorry, I meant to submit this second commit as a new pull request. I'm still somewhat new to Git and am still fumbling my way around. |
Member
|
Thanks @willisd2! Merged and updated the feature layers example accordingly. |
ScottONeal
added a commit
to ScottONeal/angular-esri-map
that referenced
this pull request
Jul 28, 2015
…ade in merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation allows an array of strings to be passed to
the esriLoader, but $q Resolves only support 1 parameter. Therefore, in
your .then() function you would only ever get the first module in your
list. The esriLoader will now take a callback function that will be passed
all of the requested modules. The original implementation is also
intact so as not to break an application if someone decides to update to
this version.