fix(t9n): make TypeScript inline .json type imports #10804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
added
the
skip visual snapshots
github-actions
bot
added this to the
2024-11-26 - 3.0.0 Nov Breaking Change Milestone milestone
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
**Related Issue:** #10803 ## Summary Subtly change the JSON type imports to encourage TypeScript to inline these in the final .d.ts files, rather than preserve them as `.json` imports. Opened an issue 2047 in AWC to add a build-time error if any .json import appears in the public .d.ts file. We can extend that as needed
Member
Author
|
For future reference: I found a consistent way to force typescript to inline the type of a type only json import: import type T9nStrings from "./assets/t9n/messages.en.json";
const identity = <T>(value: T): T => value;
const messages = identity<typeof T9nStrings>;
type Messages = ReturnType<typeof messages>;The Openned TypeScript issue: microsoft/TypeScript#61614 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10803
Summary
Subtly change the JSON type imports to encourage TypeScript to inline these in the final .d.ts files, rather than preserve them as
.jsonimports.Opened an issue 2047 in AWC to add a build-time error if any .json import appears in the public .d.ts file. We can extend that as needed