fix: move esriConfig in disconnected enviro sample#593
Merged
omarkawach merged 5 commits intomainfrom Oct 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR relocates the esriConfig configuration from JavaScript (main.js) to the HTML file (index.html) to ensure it's set before any ArcGIS modules load. This follows best practices for disconnected environment setups where early configuration is critical.
Key Changes
- Removed
esriConfigimport and configuration frommain.js - Added inline
<script>block inindex.htmlto setglobalThis.esriConfigbefore module loading - Updated code comments to reflect the new configuration location
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| component-samples/disconnected-environment/main.js | Removed esriConfig import and configuration, updated comments to exclude reference to @arcgis/core assets |
| component-samples/disconnected-environment/index.html | Added inline script block to configure esriConfig globally before any modules load |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dasa
approved these changes
Oct 23, 2025
| globalThis.esriConfig = { | ||
| assetsPath: "./assets", | ||
| // Optional: point to your Enterprise /portal/apps/fonts directory | ||
| // fontsUrl: "https://<your-enterprise-portal>.com/portal/apps/fonts/", |
Member
There was a problem hiding this comment.
Maybe also add something like:
// portalUrl: "https://<your-enterprise-portal>.com/portal",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated due to the fact the esriConfig should be set as early as possible, otherwise requests to
js.arcgis.comwill be made.