update http to https#44
Merged
puneet-pdx merged 4 commits intomainfrom Nov 18, 2020
Merged
Conversation
esreli
suggested changes
Nov 16, 2020
Contributor
esreli
left a comment
esreli
left a comment
There was a problem hiding this comment.
The work captured in source and doc look good. Because this work will constitute a patch release, would you please update the app version to correlate with the stated release, 1.0.9?
| @@ -1,3 +1,8 @@ | |||
| # Release 1.0.9 | |||
|
|
|||
| - Updates doc to avoid all use of `http:` | |||
Contributor
There was a problem hiding this comment.
This work makes changes to doc as well as source code. As such, I suggest we modify this line to read,
Suggested change
| - Updates doc to avoid all use of `http:` | |
| - Updates project to favor the use of secured `https` rather than `http` |
Collaborator
Author
@esreli I have addressed your comments |
esreli
approved these changes
Nov 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httptohttpsRelease.md