Failure to parse Paper Dev Builds

[ThioJoe]

Type of bug

Compatibility issue

/ess dump all output

N/A

Error log (if applicable)

No response

Bug description

EssentialsX fails to start when running a dev build of PaperMC. It says:

Caused by: java.lang.IllegalArgumentException: 26.1.1.build.14-alpha is not in valid version format. e.g. 1.8.8-R0.1

Full relevant logs (expand details):

Details

[03:06:45] [Server thread/INFO]: [Essentials] Enabling Essentials v2.22.0-dev+75-8e3b24f
[03:06:45] [Server thread/ERROR]: [Essentials] java.lang.ExceptionInInitializerError
java.lang.ExceptionInInitializerError
	at EssentialsX-2.22.0-dev+75-8e3b24f.jar//com.earth2me.essentials.Essentials.initAdventureFacet(Essentials.java:616) ~[?:?]
	at EssentialsX-2.22.0-dev+75-8e3b24f.jar//com.earth2me.essentials.Essentials.onEnable(Essentials.java:215) ~[?:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:279) ~[paper-api-26.1.1.build.14-alpha.jar:?]
	at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:207) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-api-26.1.1.build.14-alpha.jar:?]
	at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:637) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:594) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at net.minecraft.server.MinecraftServer.initPostWorld(MinecraftServer.java:680) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:386) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1290) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:304) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at java.base/java.lang.Thread.run(Thread.java:1474) ~[?:?]
Caused by: java.lang.IllegalArgumentException: 26.1.1.build.14-alpha is not in valid version format. e.g. 1.8.8-R0.1
	at EssentialsX-2.22.0-dev+75-8e3b24f.jar//com.earth2me.essentials.utils.VersionUtil$BukkitVersion.fromString(VersionUtil.java:262) ~[?:?]
	at EssentialsX-2.22.0-dev+75-8e3b24f.jar//com.earth2me.essentials.utils.VersionUtil.getServerBukkitVersion(VersionUtil.java:129) ~[?:?]
	at EssentialsX-2.22.0-dev+75-8e3b24f.jar//com.earth2me.essentials.utils.VersionUtil.<clinit>(VersionUtil.java:53) ~[?:?]
	... 13 more
[03:06:45] [Server thread/ERROR]: Error occurred while enabling Essentials v2.22.0-dev+75-8e3b24f (Is it up to date?)
java.lang.NullPointerException: Cannot invoke "net.ess3.provider.ServerStateProvider.isStopping()" because the return value of "com.earth2me.essentials.Essentials.provider(java.lang.Class)" is null
	at EssentialsX-2.22.0-dev+75-8e3b24f.jar//com.earth2me.essentials.Essentials.onDisable(Essentials.java:538) ~[?:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:285) ~[paper-api-26.1.1.build.14-alpha.jar:?]
	at EssentialsX-2.22.0-dev+75-8e3b24f.jar//com.earth2me.essentials.Essentials.handleCrash(Essentials.java:1117) ~[?:?]
	at EssentialsX-2.22.0-dev+75-8e3b24f.jar//com.earth2me.essentials.Essentials.onEnable(Essentials.java:461) ~[?:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:279) ~[paper-api-26.1.1.build.14-alpha.jar:?]
	at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:207) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-api-26.1.1.build.14-alpha.jar:?]
	at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:637) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:594) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at net.minecraft.server.MinecraftServer.initPostWorld(MinecraftServer.java:680) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:386) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1290) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:304) ~[paper-26.1.1.jar:26.1.1-14-f6d2701]
	at java.base/java.lang.Thread.run(Thread.java:1474) ~[?:?]

---

The problem is here:

Essentials/Essentials/src/main/java/com/earth2me/essentials/utils/VersionUtil.java

Line 193 in 8e3b24f

private static final Pattern VERSION_PATTERN = Pattern.compile("^(\\d+)\\.(\\d+)\\.?([0-9]*)?(?:-snapshot-(\\d+))?(?:-pre-?(\\d+))?(?:-rc-?(\\d+))?(?:-?R?([\\d.]+))?(?:-SNAPSHOT)?");

Steps to reproduce

• Use paper dev build from: https://papermc.io/downloads/paper
• Try to launch server

Expected behaviour

It parses the version correctly.

Actual behaviour

It doesn't recognize the version and refuses to run.

Additional Information

No response

[JasonHorkles]

Thanks for reporting, Theo!
Fixed on 2.22.0-dev+76-5d535dc via #6480 (ignore the duplicate PR 😉)