Use Paper's new ServerListPingEvent methods if present#1436
Merged
SupaHam merged 2 commits intoEssentialsX:2.xfrom Aug 4, 2017
Merged
Use Paper's new ServerListPingEvent methods if present#1436SupaHam merged 2 commits intoEssentialsX:2.xfrom
SupaHam merged 2 commits intoEssentialsX:2.xfrom
Conversation
SupaHam
requested changes
Aug 3, 2017
| public class EssentialsServerListener implements Listener { | ||
| private final transient IEssentials ess; | ||
| private boolean errorLogged = false; | ||
| private Boolean isPaperSample; |
Member
Author
There was a problem hiding this comment.
Leftover of previous messy implementation, will change now
| if (ess.getUser(player).isVanished()) { | ||
| iterator.remove(); | ||
| if (isPaperSample) { | ||
| // ess.getLogger().info("Paper sample"); |
Member
Author
|
@SupaHam Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1419 - as of the Paper patch that added the new methods, there's now no way to change the server list player count on Paper 1.12+, but this PR fixes the names of vanished players showing up in the server list.
Tested against Spigot 1.12.1 and Paper 1.12.1, latest builds as of submitting PR.