Add events for ban, ipban and extend mute event#3024
Conversation
pop4959
left a comment
pop4959
left a comment
There was a problem hiding this comment.
Needs to resolve merge conflicts.
|
In addition to the comment above, can you please make a PR for each of these individually? This will help reviewers evaluate each one without having to read through everything else. |
pop4959
added
the
status: waiting on author
…api/bans � Conflicts: � Essentials/src/com/earth2me/essentials/User.java � Essentials/src/com/earth2me/essentials/commands/Commandmute.java � Essentials/src/net/ess3/api/events/MuteStatusChangeEvent.java
|
Somehow I forgot about this but I merged it now, can you reopen? And I don't think its needed to split this into multiple PRs, basically they all are about one thing. |
pop4959
removed
the
status: waiting on author
|
@js6pak Thanks. I understand that it is a bit of work for you to redo this at this point, so it's fine, but try to keep this in mind next time you make a PR. Smaller more concise diffs will help reviewers get through it faster. Also, a problem with one change in the PR will not block another change. As is, we're going to have to either accept or deny, merge or revert, all of the changes in this PR if one has a problem. Not that it's necessarily a big issue for this PR, due to how closely knit the changes are. Just a word of advice and something to consider. |
|
Apologies for the slow response to this PR - been caught up in other stuff lately. It's not entirely clear to me what the new tempmute and tempban events represent compared to the existing mute/ban events - could you elaborate on this (and ideally add a Javadoc comment on the classes)? |
mdcfe
added
the
status: waiting on author
Currently there are no ban/ipban events (and mute event was missing something but I can't remember what exactly now). This PR just adds them. |
Chew
added
the
status: needs manual rebase
|
Closing because it seems this PR has gone stale. I also don't really see any comprehensive argument for adding them, since as MD mentioned in the other issue plugins can easily just be listening in to commands as well. |
4 participants
Properly resolves #2100
I'm still very open to name suggestions (i really don't know how to name these events)