Skip to content

[WIP] Replace old Settings config with a self updating config#3513

Closed
JRoy wants to merge 24 commits into
EssentialsX:2.xfrom
JRoy:feature/better-config
Closed

[WIP] Replace old Settings config with a self updating config#3513
JRoy wants to merge 24 commits into
EssentialsX:2.xfrom
JRoy:feature/better-config

Conversation

@JRoy
Copy link
Copy Markdown
Member

@JRoy JRoy commented Jul 18, 2020

This is inspired by and builds on top of ChestShop's Breeze configuration system to automatically update configs.

When finished, this PR will add config options, in their designed order, when they are added while keeping existing values and comments.

This PR is in very early stages and is bare-bones, doesn't work lol, and is NOT TESTED. Please do not use this yet.

TODO:

  • get it to work lol
  • make subsections work (find depth by splitting by . then multiply that by 2 spaces to write into config)
    • maybe process them differently?
  • annotation for hidden fields
  • replace settings API with new config API
  • backfill Settings API with new config API
    • for dynamic settings fetchers, use a MethodHandle cache to statically invoke fields

@JRoy JRoy added the type: enhancement Features and feature requests. label Jul 18, 2020
@JRoy JRoy closed this Jan 2, 2021
@JRoy JRoy deleted the feature/better-config branch March 30, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Features and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant