Fixed unreachable nickNoMore Message in /nick command. Not a huge change. #6442
Merged
mdcfe merged 1 commit intoEssentialsX:2.xfrom Feb 21, 2026
Merged
Fixed unreachable nickNoMore Message in /nick command. Not a huge change. #6442mdcfe merged 1 commit intoEssentialsX:2.xfrom
mdcfe merged 1 commit intoEssentialsX:2.xfrom
Conversation
…nge. The display name was comparing getDisplayName() to itself, making it always true which made the nickNoMore message unreachable. Now it uses FormatUtil.stripFormat() to strip color codes before comparing against getName(), also has a null-safety guard.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the /nick command where the nickNoMore message was unreachable due to a logical error. The code was comparing getDisplayName() to itself instead of comparing the stripped display name to the actual player name. The fix properly strips color codes from the display name before comparing it to the player's real name, and adds appropriate null safety.
Changes:
- Fixed unreachable
nickNoMoremessage in the/nickcommand by correcting the comparison logic - Added proper null safety guard when checking if a nick equals the username
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mdcfe
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The display name was comparing getDisplayName() to itself, making it always true which made the nickNoMore message unreachable. Now it uses FormatUtil.stripFormat() to strip color codes before comparing against getName(), also has a null-safety guard.
I have built it locally and tested it - it works well. Verified: "Nick set normally", "Nick equal to Username", "Colored nick equal to Username". Had no Errors.