feat(brainbar): stamp builds with git commit + UTC time in Info.plist#264
feat(brainbar): stamp builds with git commit + UTC time in Info.plist#264
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
@codex review |
📝 WalkthroughWalkthroughThe build script Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Excellent! Everything is in perfect order. Let me now create a concise summary for the user: Bugbot Review Complete ✅I've completed a comprehensive review of PR #264 (feat/brainbar-build-stamp) and taken proactive action to improve the code. What I Found✅ Overall: APPROVED - The build provenance stamping implementation is well-designed and correctly integrated. Key findings:
Issue Identified & FixedMinor quoting issue in
Test Results
Changes PushedRisk Level: 🟢 LOW (build script only, no runtime changes, easy rollback) Final Verdict: PR is production-ready and approved for merge. The fix I applied makes it more robust against edge cases. |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 88c9b0c. Configure here.
- Add double quotes around $value in plist_set_string function - Prevents potential issues if git describe output contains spaces - Low risk fix identified during bugbot review - All 10 verification tests still passing Co-authored-by: Etan Heyman <EtanHey@users.noreply.github.com>
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
- Recent Hardening section traces each claim to a merged PR - BrainBar build-script guards (#264, #265) called out at the install step - Phase B preventive infra block (orchestrator#58, #60) connects deploy registry to the BrainBar build-stamp + canonical-build refuse layer - In-flight PR #251 entry documents NSPanel revival + trigram FTS5 startup-safety guard (10K-chunk threshold) + preserved /tmp/brainbar.sock pub/sub plane Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Recent Hardening section traces each claim to a merged PR - BrainBar build-script guards (#264, #265) called out at the install step - Phase B preventive infra block (orchestrator#58, #60) connects deploy registry to the BrainBar build-stamp + canonical-build refuse layer - In-flight PR #251 entry documents NSPanel revival + trigram FTS5 startup-safety guard (10K-chunk threshold) + preserved /tmp/brainbar.sock pub/sub plane Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…267) - Recent Hardening section traces each claim to a merged PR - BrainBar build-script guards (#264, #265) called out at the install step - Phase B preventive infra block (orchestrator#58, #60) connects deploy registry to the BrainBar build-stamp + canonical-build refuse layer - In-flight PR #251 entry documents NSPanel revival + trigram FTS5 startup-safety guard (10K-chunk threshold) + preserved /tmp/brainbar.sock pub/sub plane Co-authored-by: Test User <test@example.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>



Summary
GitCommit,GitDescribe, andBuildTimeUTCinInfo.plistbrain-bar/build-app.shbefore signing so deployed bundles carry provenanceWhy
Verification
bash -n brain-bar/build-app.shuv sync --extra dev --extra clouduv run --extra dev pytest -v --tb=short tests/test_git_learning.py::test_brain_learn_git_seeds_single_repo_without_duplicates tests/test_phase3_digest.py::test_digest_content_returns_structured_result tests/test_phase3_digest.py::test_digest_content_creates_chunk tests/test_phase3_digest.py::test_digest_content_extracts_entities tests/test_phase3_digest.py::test_digest_content_applies_sentiment tests/test_phase3_digest.py::test_digest_content_confidence_tiers tests/test_phase3_digest.py::test_digest_extracts_action_items tests/test_phase3_digest.py::test_full_digest_pipeline tests/test_smart_search_entity_dedup.py::TestDigestEntityDedup::test_digest_deduplicates_repeated_entity_mentions tests/test_smart_search_entity_dedup.py::TestDigestEntityDedup::test_digest_deduplicates_case_variantsbash scripts/run_tests.shContext
orchestrator/collab/2026-05-01-brainlayer-split-brain-architecture-decision.mdNote
Low Risk
Low risk: build-script-only change that adds metadata to the generated
.appbundle; main risk is build failures on environments lackinggitmetadata orPlistBuddybehavior differences.Overview
Adds build provenance stamping to
brain-bar/build-app.shby writingGitCommit,GitDescribe, andBuildTimeUTCinto the generated app bundle’sInfo.plist(viaPlistBuddy) before codesigning, and logs the stamped values during the build.Reviewed by Cursor Bugbot for commit 2e4ae97. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Stamp brain-bar app bundle Info.plist with git commit and UTC build time
Updates build-app.sh to write
GitCommit,GitDescribe, andBuildTimeUTCkeys intoInfo.plistafter copying it into the app bundle. Three helper functions capture the git SHA, descriptive ref, and RFC3339 UTC timestamp, and aplist_set_stringhelper usesPlistBuddyto add or update each key. The stamped values are printed to stdout during the build.Macroscope summarized 2e4ae97.
Summary by CodeRabbit