Skip to content

GH-184 Refactor Knockback Mechanic and Add Support for Deny Entry flag#184

Merged
CitralFlo merged 13 commits intomasterfrom
worldguard-pvp
Sep 22, 2024
Merged

GH-184 Refactor Knockback Mechanic and Add Support for Deny Entry flag#184
CitralFlo merged 13 commits intomasterfrom
worldguard-pvp

Conversation

@CitralFlo
Copy link
Copy Markdown
Member

@CitralFlo CitralFlo commented Sep 18, 2024

Added features:

  • block of entry to regions with PVP flag from WorldGuard
    Rework:
  • Knockback multiplayer
  • Knockback direction

@CitralFlo
Copy link
Copy Markdown
Member Author

CitralFlo commented Sep 18, 2024

To be honest many features require delay to messages. Thus delay in my opinion should be added to multification, which we plan to add to EternalCombat

@CitralFlo CitralFlo changed the title Worldguard pvp GH-184 Knockback rework and Flag.PVP deny entry support Sep 18, 2024
@CitralFlo
Copy link
Copy Markdown
Member Author

CitralFlo commented Sep 18, 2024

Mend security detects Guava as always

igoyek
igoyek approved these changes Sep 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@igoyek igoyek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Mike :)

Comment thread eternalcombat-api/src/main/java/com/eternalcode/combat/config/implementation/PluginConfig.java
This was linked to issues Sep 18, 2024
Deny do entry to the region has a bugs. #156
Closed
Safe Zone entry prevention is poorly implemented #95
Closed
vLuckyyy
vLuckyyy reviewed Sep 18, 2024
View reviewed changes
Comment thread eternalcombat-api/src/main/java/com/eternalcode/combat/region/DefaultRegionProvider.java Outdated
Comment thread eternalcombat-api/src/main/java/com/eternalcode/combat/region/RegionMain.java Outdated
Comment thread eternalcombat-api/src/main/java/com/eternalcode/combat/region/WorldGuardRegionProvider.java Outdated
Comment thread eternalcombat-api/src/main/java/com/eternalcode/combat/region/WorldGuardRegionProvider.java
P1otrulla
P1otrulla approved these changes Sep 20, 2024
View reviewed changes
Comment thread eternalcombat-api/src/main/java/com/eternalcode/combat/region/RegionMain.java Outdated
@vLuckyyy vLuckyyy changed the title GH-184 Knockback rework and Flag.PVP deny entry support GH-184 Refactor Knockback Mechanic and Add Support for Deny Entry flag Sep 21, 2024
@CitralFlo CitralFlo merged commit 20a4e4a into master Sep 22, 2024
@CitralFlo CitralFlo deleted the worldguard-pvp branch September 22, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rollczi Rollczi Rollczi approved these changes

@vLuckyyy vLuckyyy vLuckyyy approved these changes

@igoyek igoyek igoyek approved these changes

@P1otrulla P1otrulla P1otrulla approved these changes

@Kamicjusz Kamicjusz Awaiting requested review from Kamicjusz

@Jakubk15 Jakubk15 Awaiting requested review from Jakubk15

@eripe14 eripe14 Awaiting requested review from eripe14

@VerniQ VerniQ Awaiting requested review from VerniQ

@imDMK imDMK Awaiting requested review from imDMK

@Kazaruma Kazaruma Awaiting requested review from Kazaruma

+1 more reviewer

@Hyd3r1 Hyd3r1 Hyd3r1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deny do entry to the region has a bugs. Safe Zone entry prevention is poorly implemented

6 participants

@CitralFlo @Rollczi @Hyd3r1 @vLuckyyy @igoyek @P1otrulla