GH-232 Fix head drop

[vLuckyyy]

No description provided.

[coderabbitai]

Walkthrough

The updates add a new parameter, MiniMessage, to the DropController class and its usage, affecting how player head drops are displayed in the game. The logic for checking if a player can be tagged in combat was reorganized for clarity, but its behavior remains similar. The way dropped experience and player head items are handled was improved, with enhancements to the appearance and formatting of dropped player heads. No public method signatures were changed except for the addition of the new constructor parameter in DropController.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba5fa97 and af9f6ee.

📒 Files selected for processing (3)

• eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatPlugin.java (1 hunks)
• eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/controller/FightTagController.java (1 hunks)
• eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/drop/DropController.java (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

🔇 Additional comments (7)

eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatPlugin.java (1)

184-184: LGTM! Constructor parameter addition looks correct.

The miniMessage parameter is properly passed to match the updated DropController constructor.

eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/controller/FightTagController.java (1)

149-158: Good refactoring for improved readability!

Breaking down the conditions into separate checks makes the logic much clearer and easier to follow.

eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/drop/DropController.java (5)

30-41: Constructor update looks good!

Adding the MiniMessage parameter properly supports the enhanced formatting features.

---

79-79: Correct usage of modified result!

Using result.droppedExp() instead of the original drop value makes sense since we want the modified experience value.

---

83-97: Nice refactoring of the head drop logic!

The restructured conditions are much clearer:

1. Early return if disabled
2. Handle combat-only requirement
3. Check probability

This flow is easier to understand than the previous logic.

---

109-109: Great enhancement with MiniMessage formatting!

Using MiniMessage for display names and lore will provide much better text formatting support. The deserialization and serialization chain properly handles the formatting.

Also applies to: 113-117

---

122-124: Nice visual touch with the enchantment!

Adding the lure enchantment and hiding it with ItemFlag makes the player heads look more special while keeping them clean visually.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.