GH-1218 Add error message for incorrect stack number and update validation logic #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
new.messages.mp4 |
CitralFlo
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the validation logic and error messages for the stack amount argument in commands. The changes are solid, particularly the improved validation to reject non-positive stack amounts and the more specific error message for invalid number formats. I've identified a couple of minor issues: an outdated command usage description and inconsistent visibility for newly added configuration fields. Addressing these will improve documentation accuracy and code consistency.
eternalcore-core/src/main/java/com/eternalcode/core/feature/item/ItemCommand.java
Show resolved
Hide resolved
...ore/src/main/java/com/eternalcode/core/litecommand/argument/messages/PLArgumentMessages.java
Outdated
Show resolved
Hide resolved
Rollczi
approved these changes
Oct 19, 2025
P1otrulla
approved these changes
Oct 20, 2025
Jakubk15
approved these changes
Oct 20, 2025
vLuckyyy
requested changes
Oct 20, 2025
| public Notice onlyPlayer = Notice.chat("<red>✘ <dark_red>Command is only for players!"); | ||
| public Notice numberBiggerThanZero = Notice.chat("<red>✘ <dark_red>The number must be greater than 0!"); | ||
| public Notice numberBiggerThanOrEqualZero = Notice.chat("<red>✘ <dark_red>The number must be greater than or equal to 0!"); | ||
| Notice stackNumberIncorrect = Notice.chat("<red>✘ <dark_red><bold>Incorrect number!"); |
| public Notice onlyPlayer = Notice.chat("<red>✘ <dark_red>Ta komenda jest dostępna tylko dla graczy!"); | ||
| public Notice numberBiggerThanZero = Notice.chat("<red>✘ <dark_red>Liczba musi być większa od 0!"); | ||
| public Notice numberBiggerThanOrEqualZero = Notice.chat("<red>✘ <dark_red>Liczba musi być równa lub większa od 0!"); | ||
| Notice stackNumberIncorrect = Notice.chat("<red>✘ <dark_red><bold>Niepoprawna liczba!"); |
# Conflicts: # eternalcore-core/src/main/java/com/eternalcode/core/litecommand/argument/messages/ENArgumentMessages.java # eternalcore-core/src/main/java/com/eternalcode/core/litecommand/argument/messages/PLArgumentMessages.java
vLuckyyy
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some suggestion from LiteCommands in StackAmountArgument found during tests of GH-1214. Additionally better messages for error validation.