Skip to content

GH-1218 Add error message for incorrect stack number and update validation logic #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2025
Merged

GH-1218 Add error message for incorrect stack number and update validation logic #1218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2fc58a
Add error message for incorrect stack number and update validation logic
CitralFlo Oct 19, 2025
d72b8cc
Merge branch 'master' into StackAmountArgument-and-item-litecommand-warn
vLuckyyy Oct 20, 2025
90d6df9
Remove `<bold>` to use follow other messages' layout.
vLuckyyy Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions eternalcore-core/src/main/java/com/eternalcode/core/feature/item/ItemCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
import dev.rollczi.litecommands.annotations.command.Command;
import dev.rollczi.litecommands.annotations.context.Context;
import dev.rollczi.litecommands.annotations.execute.Execute;
import dev.rollczi.litecommands.annotations.optional.OptionalArg;
import dev.rollczi.litecommands.annotations.permission.Permission;
import org.bukkit.Material;
import org.bukkit.entity.Player;
Expand Down Expand Up @@ -38,7 +37,7 @@ void execute(@Context Player player, @Arg Material material) {

@Execute
@DescriptionDocs(description = "Gives an item with a custom amount", arguments = "<item> [amount]")
void execute(@Context Player player, @Arg Material material, @OptionalArg(StackAmountArgument.KEY) int amount) {
void execute(@Context Player player, @Arg Material material, @Arg(StackAmountArgument.KEY) int amount) {
boolean isSuccess = this.giveService.giveItem(player, player, material, amount);

if (isSuccess) {
Expand Down
6 changes: 3 additions & 3 deletions ...ore-core/src/main/java/com/eternalcode/core/litecommand/argument/StackAmountArgument.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@ public ParseResult<Integer> parse(Invocation<CommandSender> invocation, String a
try {
int value = Integer.parseInt(argument);

if (value < 0) {
return ParseResult.failure(translation.argument().numberBiggerThanOrEqualZero());
if (value <= 0) {
return ParseResult.failure(translation.argument().numberBiggerThanZero());
}

return ParseResult.success(value);
}
catch (NumberFormatException exception) {
return ParseResult.failure(translation.argument().numberBiggerThanOrEqualZero());
return ParseResult.failure(translation.argument().stackNumberIncorrect());
}
}

Expand Down
1 change: 1 addition & 0 deletions ...re/src/main/java/com/eternalcode/core/litecommand/argument/messages/ArgumentMessages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public interface ArgumentMessages {
Notice onlyPlayer();
Notice numberBiggerThanZero();
Notice numberBiggerThanOrEqualZero();
Notice stackNumberIncorrect();
Notice noItem();
Notice noArgument();
Notice worldDoesntExist();
Expand Down
1 change: 1 addition & 0 deletions .../src/main/java/com/eternalcode/core/litecommand/argument/messages/ENArgumentMessages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public class ENArgumentMessages extends OkaeriConfig implements ArgumentMessages
Notice onlyPlayer = Notice.chat("<red>✘ <dark_red>Command is only for players!");
Notice numberBiggerThanZero = Notice.chat("<red>✘ <dark_red>The number must be greater than 0!");
Notice numberBiggerThanOrEqualZero = Notice.chat("<red>✘ <dark_red>The number must be greater than or equal to 0!");
Notice stackNumberIncorrect = Notice.chat("<red>✘ <dark_red>Incorrect number!");
Notice noItem = Notice.chat("<red>✘ <dark_red>You need item to use this command!");
Notice noMaterial = Notice.chat("<red>✘ <dark_red>This item doesn't exist");
Notice noArgument = Notice.chat("<red>✘ <dark_red>This argument doesn't exist");
Expand Down
1 change: 1 addition & 0 deletions .../src/main/java/com/eternalcode/core/litecommand/argument/messages/PLArgumentMessages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public class PLArgumentMessages extends OkaeriConfig implements ArgumentMessages
Notice onlyPlayer = Notice.chat("<red>✘ <dark_red>Ta komenda jest dostępna tylko dla graczy!");
Notice numberBiggerThanZero = Notice.chat("<red>✘ <dark_red>Liczba musi być większa od 0!");
Notice numberBiggerThanOrEqualZero = Notice.chat("<red>✘ <dark_red>Liczba musi być równa lub większa od 0!");
Notice stackNumberIncorrect = Notice.chat("<red>✘ <dark_red><Niepoprawna liczba!");
Notice noItem = Notice.chat("<red>✘ <dark_red>Musisz trzymać przedmiot w dłoni!");
Notice noMaterial = Notice.chat("<red>✘ <dark_red>Taki materiał nie istnieje!");
Notice noArgument = Notice.chat("<red>✘ <dark_red>Taki argument nie istnieje!");
Expand Down