Merged
Conversation
…munication. With NullMarked as clear way to display notnull by default. Nullmarks checked to second layer of services. Additional `NotNull` s from jetbrains required by intelliJ to not screen about parameter marks as notNull
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces JSpecify annotations across the API to improve null-safety, which is a great step forward for code quality and Kotlin interoperability. The use of @NullMarked correctly sets non-null as the default for many interfaces and classes.
My review focuses on a few key areas:
- I've pointed out several places where collection return types are incorrectly marked as containing
@Nullableelements, while their implementations guarantee non-null elements. This misrepresents the API contract and should be corrected. - I've also raised a concern about removing runtime null checks from a public event constructor. While static analysis is helpful, runtime checks provide an essential safeguard against incorrect API usage from un-checked code.
Overall, the changes are positive, and addressing these points will further solidify the null-safety of the API.
eternalcore-api/src/main/java/com/eternalcode/core/feature/adminchat/event/AdminChatEvent.java
Outdated
Show resolved
Hide resolved
eternalcore-api/src/main/java/com/eternalcode/core/feature/catboy/CatboyService.java
Outdated
Show resolved
Hide resolved
eternalcore-api/src/main/java/com/eternalcode/core/feature/jail/JailService.java
Outdated
Show resolved
Hide resolved
eternalcore-api/src/main/java/com/eternalcode/core/feature/vanish/VanishService.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/feature/jail/JailServiceImpl.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/feature/warp/WarpServiceImpl.java
Outdated
Show resolved
Hide resolved
…boy/CatboyService.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…inchat/event/AdminChatEvent.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…l/JailService.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…rp/WarpServiceImpl.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Jakubk15
reviewed
Feb 7, 2026
Member
Jakubk15
left a comment
There was a problem hiding this comment.
Overall good PR, minor tweaks required
eternalcore-api/src/main/java/com/eternalcode/core/feature/adminchat/event/AdminChatEvent.java
Outdated
Show resolved
Hide resolved
eternalcore-api/src/main/java/com/eternalcode/core/feature/adminchat/event/AdminChatEvent.java
Show resolved
Hide resolved
eternalcore-api/src/main/java/com/eternalcode/core/feature/catboy/CatboyService.java
Outdated
Show resolved
Hide resolved
eternalcore-api/src/main/java/com/eternalcode/core/feature/spawn/SpawnService.java
Outdated
Show resolved
Hide resolved
eternalcore-api/src/main/java/com/eternalcode/core/feature/vanish/VanishService.java
Outdated
Show resolved
Hide resolved
eternalcore-api/src/main/java/com/eternalcode/core/feature/warp/event/PreWarpTeleportEvent.java
Outdated
Show resolved
Hide resolved
eternalcore-api/src/main/java/com/eternalcode/core/EternalCoreApiProvider.java
Show resolved
Hide resolved
eternalcore-api/src/main/java/com/eternalcode/core/EternalCoreApiProvider.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/feature/spawn/SpawnServiceImpl.java
Outdated
Show resolved
Hide resolved
Jakubk15
reviewed
Feb 7, 2026
eternalcore-api/src/main/java/com/eternalcode/core/EternalCoreApiProvider.java
Outdated
Show resolved
Hide resolved
…wn/SpawnService.java
…awn/SpawnServiceImpl.java
…p/event/PreWarpTeleportEvent.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My understanding of JSpecify for api - mostly used in Java-Kotlin communication. With NullMarked as clear way to display notnull by default. Nullmarks checked to second layer of services. Additional NotNull s from jetbrains required by intelliJ to not screen about parameter marks as notNull