GH-301 Dependency loader (Resolve #301) #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .editorconfig # core/build.gradle.kts
# Conflicts: # buildSrc/src/main/kotlin/eternalcode.java-conventions.gradle.kts
# Conflicts: # buildSrc/src/main/kotlin/eternalcode.java-conventions.gradle.kts # core/build.gradle.kts # core/src/main/java/com/eternalcode/core/EternalCore.java
# Conflicts: # core/build.gradle.kts # core/src/main/java/com/eternalcode/core/EternalCore.java # settings.gradle.kts
P1otrulla
approved these changes
Apr 8, 2023
plugin/src/main/java/com/eternalcode/core/loader/dependency/DependencyCollector.java
Show resolved
Hide resolved
Jakubk15
approved these changes
Apr 9, 2023
Member
Jakubk15
left a comment
Jakubk15
left a comment
There was a problem hiding this comment.
Sporo zmian, szacun za podjęcie się tego, nie mogłem wyłapać żadnych innych błędów, napraw tylko kompilację. Z pewnością będzie jeszcze trzeba to przetestować, jak z wydajnością, itp. Powiedz mi jeszcze czy udało ci się rozwiązać to w taki sposób, aby nie pobierało 2x biblioteki z maven central czy coś w tym stylu, pamiętasz o co mi chodzi chyba. Na dc o tym rozmawialiśmy 😸
vLuckyyy
requested changes
Apr 9, 2023
Member
vLuckyyy
left a comment
vLuckyyy
left a comment
There was a problem hiding this comment.
Zaktualizuj CI do swoich zmian
Jakubk15
approved these changes
Apr 10, 2023
Co-authored-by: Jakubk15 <77227023+Jakubk15@users.noreply.github.com>
Co-authored-by: Jakubk15 <77227023+Jakubk15@users.noreply.github.com>
Co-authored-by: Jakubk15 <77227023+Jakubk15@users.noreply.github.com>
Co-authored-by: Jakubk15 <77227023+Jakubk15@users.noreply.github.com>
vLuckyyy
approved these changes
Apr 10, 2023
Jakubk15
approved these changes
Apr 10, 2023
vLuckyyy
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.