Skip to content

fix: chart rendering with options update on different units#947

Merged
olgakup merged 9 commits intodevelopfrom
bug/unique-chart
Dec 23, 2020
Merged

fix: chart rendering with options update on different units#947
olgakup merged 9 commits intodevelopfrom
bug/unique-chart

Conversation

@olgakup
Copy link
Copy Markdown
Contributor

@olgakup olgakup commented Dec 17, 2020

This fixes bugs when switching between different time options on unique charts:

  • x and y are too far apart with stepSize of 1 minute
  • Cannot set property 'font' of null
  • Cannot read property 'skip' of undefined
  • Cannot read property 'getTimeseriesData' of undefined
  • GraphQL execution errors: 'From timestamp is larger than to timestamp'

@olgakup olgakup added bug Ready For Review This PR is completed, reviewers can start review process labels Dec 17, 2020
@olgakup olgakup self-assigned this Dec 17, 2020
@olgakup olgakup requested a review from kvhnuke as a code owner December 17, 2020 21:39
@olgakup olgakup added ready and removed Ready For Review This PR is completed, reviewers can start review process labels Dec 23, 2020
@olgakup olgakup merged commit b5ca1b0 into develop Dec 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the bug/unique-chart branch December 23, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants