Conversation
When importing images, decode them to a capped resolution before saving to reduce file size and memory usage. Should fix issue #190
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #190 which caused crashes when attempting to draw excessively large bitmaps on the Android canvas. The solution introduces automatic image resizing during import to prevent memory exhaustion and canvas size limit violations. Images are now decoded with a maximum resolution based on screen dimensions (minimum 2048 pixels, or 2x the screen dimensions, whichever is larger) while preserving aspect ratios.
Changes:
- Added image resizing logic using ImageDecoder API to cap resolution at import time
- Refactored file handling to separate image-specific processing from generic file copying
- Added helper functions for MIME type detection and filename extraction
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| app/src/main/java/com/ethran/notable/io/FileUtils.kt | Implements new saveImageFromContentUri function with ImageDecoder-based resizing, extracts getFileNameFromUri helper, and updates createFileFromContentUri to use the extracted helper |
| app/src/main/java/com/ethran/notable/data/dbUtils.kt | Updates copyImageToDatabase to always use the new resizing function, and copyBackgroundToDatabase to conditionally resize images while copying other files unchanged |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| val quality = if (outputFormat == Bitmap.CompressFormat.PNG) 100 else 90 | ||
| resizedBitmap.compress(outputFormat, quality, out) |
There was a problem hiding this comment.
WEBP format uses the quality parameter (90) but this only applies to lossy compression. If the deprecated WEBP constant defaults to lossless compression, the quality parameter will be ignored. This could result in larger file sizes than expected. Consider explicitly using WEBP_LOSSY to ensure the quality setting is respected.
|
|
||
| mime.equals("image/webp", ignoreCase = true) || destFile.extension.equals( | ||
| "webp", true | ||
| ) -> Bitmap.CompressFormat.WEBP |
There was a problem hiding this comment.
The Bitmap.CompressFormat.WEBP constant is deprecated in API 30 and should be replaced with WEBP_LOSSY or WEBP_LOSSLESS for better control over compression. Since the app's minSdk is 29, consider using WEBP_LOSSY with appropriate quality setting or WEBP_LOSSLESS for transparency preservation.
| ) -> Bitmap.CompressFormat.WEBP | |
| ) -> Bitmap.CompressFormat.WEBP_LOSSY |
| destFile.outputStream().use { out -> | ||
| val quality = if (outputFormat == Bitmap.CompressFormat.PNG) 100 else 90 | ||
| resizedBitmap.compress(outputFormat, quality, out) | ||
| out.flush() |
There was a problem hiding this comment.
Calling flush() before the output stream is closed is redundant when using the use() block, as close() automatically flushes the stream. The explicit flush() call can be removed for cleaner code.
| out.flush() |
When importing images, decode them to a capped resolution before saving to reduce file size and memory usage.
Should fix issue #190