-
Notifications
You must be signed in to change notification settings - Fork 1
feat: New weapon tags for custom stat scaling #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I remember about this. Just hope to find some time to properly review everything. |
|
@KRdaMystic, can you recheck changed files? there seems to be a bunch of stuff unrelated to martial and savage, and in some places these tags got deleted. |
|
@sourcery-ai review |
Reviewer's Guide by SourceryThis PR introduces new weapon tags ("martial" and "savage") to enable custom stat scaling for melee attacks. Martial weapons scale with dexterity and experience, while savage weapons scale with strength and experience. Additionally, the melee attack calculation was refactored to use a modifier system. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @KRdaMystic - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the weapon tag modifier logic into a reusable function to reduce code duplication between martial and savage handling
- Replace magic numbers (40, 1000) with named constants to improve maintainability and make balance adjustments easier
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
feat: Rewrite melee weapon damage formula
|
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @KRdaMystic - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Savage & Martial tag functionality
Summary by Sourcery
Add "martial" and "savage" weapon tags to enable custom stat scaling for melee attacks.
New Features:
Tests: