Skip to content

Swift 3 support#2

Merged
dernster merged 6 commits into
masterfrom
feature/swift-3
Apr 20, 2017
Merged

Swift 3 support#2
dernster merged 6 commits into
masterfrom
feature/swift-3

Conversation

@mcousillas6
Copy link
Copy Markdown
Collaborator

Change log:

  • Updated code to match API and style changes.
  • Updated eureka to version 2.0.0-beta.1 for swift 3 support.
  • Implemented initWithCoder, now is needed.

@mcousillas6 mcousillas6 requested a review from dernster December 8, 2016 15:41
@ghost
Copy link
Copy Markdown

ghost commented Jan 17, 2017

Hello @mcousillas6,

I try to dowlload your code in Xcode 8 but it doesn't compile. I had the following errors

ld: warning: directory not found for option '-F../Carthage/Build/iOS'
ld: framework not found Eureka
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Do you have any idea to correct this ?

Regards
Sébastien

@dernster
Copy link
Copy Markdown
Member

dernster commented Feb 6, 2017

@iLandes Did you run the bin/setup script after cloning/switching to this branch?

@ghost
Copy link
Copy Markdown

ghost commented Feb 6, 2017

I do not bin/setup

@dernster
Copy link
Copy Markdown
Member

dernster commented Feb 6, 2017

@iLandes Please try it and let me know. You can follow the instructions here

@dernster dernster merged commit 2bc96b8 into master Apr 20, 2017
@dernster dernster deleted the feature/swift-3 branch April 20, 2017 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants