CI: mobile e2e smoke + drop SKIP_MOBILE from Makefile#262
Conversation
Picks up Euro-Office/web-apps#158, which removes SKIP_MOBILE from build-pipeline.js — mobile now always builds and is always gated. Required before dropping the dead SKIP_MOBILE pass-through from the Makefile. Refs #261 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Since web-apps#158 the build pipeline ignores SKIP_MOBILE, so the Makefile flag is a silent no-op. Removes the comment block, default, and both web-apps/web-apps-dev pass-throughs. Refs #261 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
verify-deploy.mjs only checks that mobile artifacts exist at build time; it can't catch a mobile editor that deploys but fails at runtime (#258 — a permanent loading skeleton, or a fatal version-mismatch dialog blocking the document load). Forces the mobile bundle deterministically via ?type=mobile (bypassing the example app's User-Agent sniffing), then asserts the rendering canvas mounts and that no framework7 error surface is showing. Both dialog (.dialog.modal-in) and notification (.notification.modal-in) surfaces are checked, since LoadingScriptError uses f7.notification rather than f7.dialog. Covers docx/xlsx/pptx/pdf. Visio is excluded: the example app has no blank vsdx create-new template to exercise. Refs #261 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
PR #262 Review IssuesIssue 1 — Canvas
|
Aiiaiiio
left a comment
There was a problem hiding this comment.
Nice one! This verbose commenting will make this a bit hard to maintain should anything change that is stated here. But at least it's obvious what is happening.
The canvas mounts from the SDK bundle regardless of doc load, so the gate false-passed when the doc never loaded. Gate on .doc-placeholder clearing (the isDocReady signal) instead, with a generous timeout. Scope is build-present-and-renders; infra faults like an unresponsive docservice channel are out of scope. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Closes #261.
web-appsto pick up docs: Add SECURITY.md #158 (removesSKIP_MOBILE), then drops the now-dead pass-through fromdevelop/setup/Makefile.e2e/tests/mobile-editor.spec.ts: a runtime smoke test for docx/xlsx/pptx/pdf mobile editors, catching the classverify-deploy.mjscan't — artifacts deploy but the editor breaks at runtime (Regression: mobile editor doesn't load in latest-dev #258).Scope
The gate verifies the mobile build is present and renders a document. It keys on the loading skeleton (
.doc-placeholder) clearing — the real "document loaded" signal — rather than the canvas, which mounts with the SDK bundle before any document loads and so can't distinguish "loaded" from "never loaded".Infra faults (e.g. an unresponsive docservice channel) are out of scope: CI runs a healthy docservice from the same image and won't produce them. A known false-pass in that mode is deferred — closing it properly needs a content-bearing sample file rather than a blank new document.
Test plan
example-page.spec.ts) unaffected.doc-placeholdernever clears)