fix(wopi): populate discovery formats and log read failures#26
Open
juliusknorr wants to merge 1 commit into
Open
fix(wopi): populate discovery formats and log read failures#26juliusknorr wants to merge 1 commit into
juliusknorr wants to merge 1 commit into
Conversation
getAllFormats swallowed read errors of the formats file, so WOPI /hosting/discovery silently listed no mimetypes. Now it warns when the file is missing/unconfigured/not an array, no longer caches an empty result on failure (retries next request), and keys the cache by filePath instead of a single process-global shared across tenants. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Julius Knorr <jus@bitgrid.net> AI-assistant: Claude Code 2.1.156 (Claude Opus 4.8 claude-opus-4-8)
juliusknorr
force-pushed
the
fix/wopi-discovery-formats
branch
from
86fca29 to
da4e4d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WOPI
/hosting/discoverylisted no mimetypes becausegetAllFormatsswallowed read errors of the formats file.documentFormatsFileis missing/unconfigured/not a JSON arrayfilePath(was a process-global shared across tenants)Hardening on top of Euro-Office/DocumentServer#118