Skip to content

Conversation

@shekharkoirala
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Preview available

Key Value
url https://visa-form.ep-preview.click
last update 2025-03-27T13:12:55.718Z

href->url updated astro

Co-authored-by: Ege Akman <me@egeakman.dev>
Copy link
Contributor

@hypha hypha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question not in diff:

  1. Do you intend to merge this after ticket sales start? Otherwise, people will not be able to fill in the form and give you their ticket ID. In the past, we published the page without the form link initially.
  2. Do you want to add it to the menu?
  3. In the google form, it says "For more details on our privacy policies, please see the EuroPython 2025 website: https://www.europython-society.org/privacy/". Technically, it is not the EP2025 website. I'd probably just say "Please refer to our privacy policies for details: https://www.europython-society.org/privacy/" (this mistake is mostly likely my bad in the first place)

@shekharkoirala
Copy link
Member Author

Question not in diff:

  1. Do you intend to merge this after ticket sales start? Otherwise, people will not be able to fill in the form and give you their ticket ID. In the past, we published the page without the form link initially.
  2. Do you want to add it to the menu?
  3. In the google form, it says "For more details on our privacy policies, please see the EuroPython 2025 website: https://www.europython-society.org/privacy/". Technically, it is not the EP2025 website. I'd probably just say "Please refer to our privacy policies for details: https://www.europython-society.org/privacy/" (this mistake is mostly likely my bad in the first place)
  1. yes, This PR will be merged ( after the corrections ) and after the ticket sales goes live.
  2. yes we need to add it to the menu ( I was looking into it)

I will update it accordingly, @hypha thanks for the review

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm <3 once @hypha point is addressed!

@egeakman
Copy link
Member

egeakman commented Mar 9, 2025

Let's merge this when the ticket sales go live!

@egeakman egeakman added the DO-NOT-MERGE Not ready to be merged yet label Mar 25, 2025
@thepetk
Copy link
Contributor

thepetk commented Mar 27, 2025

I also did a test in the form just to check if everything is fine <3

@clytaemnestra
Copy link
Contributor

@shekharkoirala can we merge this PR?

@shekharkoirala
Copy link
Member Author

@shekharkoirala can we merge this PR?

We can merge this, waiting for 1 approving review.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you are! Huge hugs!

@shekharkoirala shekharkoirala merged commit 80d7701 into ep2025 Mar 27, 2025
3 checks passed
@shekharkoirala shekharkoirala deleted the visa-form branch March 27, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO-NOT-MERGE Not ready to be merged yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants