Skip to content

Faq new style. #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 7, 2025
Merged

Faq new style. #1107

merged 7 commits into from
Apr 7, 2025

Conversation

@nikoshell
Copy link
Contributor

@nikoshell nikoshell commented Apr 3, 2025

image

@nikoshell nikoshell requested a review from clytaemnestra April 3, 2025 12:37
@europython-society
Copy link
Member

europython-society commented Apr 3, 2025 •
edited
Loading

Preview available

Key Value
url https://ep2025-faq.ep-preview.click
last update 2025-04-07T21:09:19.917Z

clytaemnestra
clytaemnestra approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@clytaemnestra clytaemnestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

egeakman
egeakman requested changes Apr 3, 2025
View reviewed changes
Copy link
Member

@egeakman egeakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work on mobile:

image

@egeakman egeakman requested a review from hypha April 3, 2025 19:17
@nikoshell nikoshell requested a review from egeakman April 3, 2025 21:17
egeakman
egeakman reviewed Apr 4, 2025
View reviewed changes
Copy link
Member

@egeakman egeakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that it is searchable now, thank you! Would love to hear @hypha's opinions as she made the original implementation.

hypha
hypha approved these changes Apr 5, 2025
View reviewed changes
Copy link
Contributor

@hypha hypha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this Marcin and thanks for the ping Ege! I am OK with the new styling.

@nikoshell nikoshell requested a review from egeakman April 7, 2025 13:42
@nikoshell nikoshell merged commit df52cc7 into ep2025 Apr 7, 2025
3 checks passed
@nikoshell nikoshell deleted the ep2025-faq branch April 7, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hypha hypha hypha approved these changes

@clytaemnestra clytaemnestra clytaemnestra approved these changes

@egeakman egeakman egeakman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nikoshell @europython-society @hypha @clytaemnestra @egeakman