Added signup forms to mentorship page and added CTA #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypha
reviewed
Jan 11, 2025
Contributor
hypha
left a comment
hypha
left a comment
There was a problem hiding this comment.
Left a some small suggestions. Other than that, there are couple of wee things that are not in this diff:
- This part now needs to change from stay tuned to register now.
website/src/content/pages/programme/mentorship.mdx
Lines 16 to 17 in 7516c18
- I think replacing "Help your mentee" to "Help them" to be consistent with the rest of the bullets.
- On the menu, is it better to call it by its full name "Speaker Mentorship" or is "Mentorship" sufficient?
egeakman
reviewed
Jan 11, 2025
Co-authored-by: Ege Akman <me@egeakman.dev>
Co-authored-by: hypha <ramble.dalloway@gmail.com>
Co-authored-by: hypha <ramble.dalloway@gmail.com>
hypha
reviewed
Jan 11, 2025
Contributor
hypha
left a comment
hypha
left a comment
There was a problem hiding this comment.
oof, just one tiny punctuation for readability. Otherwise, LGTM. <3
egeakman
approved these changes
Jan 11, 2025
Co-authored-by: hypha <ramble.dalloway@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentorship page now has links to signup forms
New CTA for mentorship, replaces CfT CTA