Fix pbxproj output differences (keys not sorted, extra properties)#46
Merged
Fix pbxproj output differences (keys not sorted, extra properties)#46
Conversation
Stop auto-populating PBXFileReference defaults (fileEncoding, includeInIndex) and avoid initializing empty input/output path arrays in PBX build phases so the library doesn't add properties Xcode omits when round-tripping projects. Add deterministic JSON writer ordering (case-sensitive ASCII with "isa" first) for stable output. Update tests to reflect the removed defaults and to skip fixtures that rely on original non-sorted key order.
Re-process project.pbxproj and project-with-entitlements.pbxproj through the parser/writer to normalize key ordering, then restore them in inOutFixtures array. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #30 - Addresses differences in pbxproj output when reading and rewriting project files.
isafirst, then case-sensitive ASCII alphabetical order (matching Xcode's behavior)fileEncodingandincludeInIndexdefaults: These properties are no longer added toPBXFileReferenceobjects unless they existed in the original fileinputPaths,outputPaths,inputFileListPaths,outputFileListPathsare no longer initialized to empty arrays (Xcode omits these when empty)Test plan
🤖 Generated with Claude Code