Skip to content

[ESDB-116-3] Improvements to projection metrics#4312

Merged
timothycoleman merged 1 commit intomasterfrom
kunaldhingra/improvements-to-projection-metrics
Jun 27, 2024
Merged

[ESDB-116-3] Improvements to projection metrics#4312
timothycoleman merged 1 commit intomasterfrom
kunaldhingra/improvements-to-projection-metrics

Conversation

@dhingrak
Copy link
Copy Markdown
Contributor

@dhingrak dhingrak commented Jun 26, 2024

Changed: Separated projections metrics into multiple instruments

Now matches https://github.com/marcinbudny/eventstore_exporter

Also

  • Fixed: No longer keeps registering additional handlers
  • Fixed: Progress is now a float so it can be values between 0 and 1

@dhingrak dhingrak changed the title Improvements to projection metrics [ESDB-116-3]Improvements to projection metrics Jun 27, 2024
@dhingrak dhingrak marked this pull request as ready for review June 27, 2024 00:44
@timothycoleman timothycoleman self-requested a review June 27, 2024 06:15
Also
- No longer keeps registering additional handlers
- Progress is now a float so it can be values between 0 and 1

Co-authored-by: Timothy Coleman <timothy.coleman@gmail.com>
@timothycoleman timothycoleman force-pushed the kunaldhingra/improvements-to-projection-metrics branch from 28f9346 to c605ab9 Compare June 27, 2024 14:39
@timothycoleman timothycoleman changed the title [ESDB-116-3]Improvements to projection metrics [ESDB-116-3] Improvements to projection metrics Jun 27, 2024
@timothycoleman timothycoleman merged commit cf9994e into master Jun 27, 2024
@timothycoleman timothycoleman deleted the kunaldhingra/improvements-to-projection-metrics branch June 27, 2024 14:57
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timothycoleman 👉 Created pull request targeting release/oss-v24.6: #4313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants