Update generate_DL2_file.py#29
Merged
GernotMaier merged 1 commit intoEventdisplay:mainfrom Sep 18, 2024
JBernete:patch-1
Merged
Update generate_DL2_file.py#29GernotMaier merged 1 commit intoEventdisplay:mainfrom JBernete:patch-1
GernotMaier merged 1 commit intoEventdisplay:mainfrom
JBernete:patch-1
Conversation
Fix simulation info to take into account the loss of events that are used in the event type training
Contributor
Author
|
Thank you for the approval! I don't have permission to merge it. |
Member
|
Merge it!Gernot---Dr Gernot MaierCTADeutsches Elektronen-Synchrotron DESY Ein Forschungszentrum der Helmholtz-GemeinschaftPlatanenallee 6, D-15738 Zeuthen, GermanyWorking hours differ and mine may not be the same as yours. Please do not feel obliged to reply to this e-mail outside of your normal working hours.On 18. Sep 2024, at 14:11, JBernete ***@***.***> wrote:
Thank you for the approval! I don't have permission to merge it.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix simulation info to take into account the loss of events that are used in the event type training.
We already validated that, with this change, the event-type-wise IRFs are computed correctly.