Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances stereo reconstruction in eventdisplay-ML by adding a new geometric feature (img2_ang - image angular resolution), adjusting size clipping for SST telescope support, and adding a configurable preview logging parameter for debugging.
Changes:
- Adds
img2_angas a new feature for stereo reconstruction to improve direction/energy estimation - Changes minimum size clipping from 10 to 1 photoelectrons to support Small Size Telescopes (SSTs) with smaller images
- Introduces
--preview_rowscommand-line parameter to control the number of events displayed in sorting preview logs
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/eventdisplay_ml/features.py | Adds img2_ang to regression feature list and clip intervals (0-360°); changes size min clip from 10 to 1 |
| src/eventdisplay_ml/data_processing.py | Adds img2_ang extraction in extra_columns(); threads preview_rows parameter through flattening functions; improves logging format to %-style |
| src/eventdisplay_ml/config.py | Adds --preview_rows CLI argument with default=20 to training and application configs |
| src/eventdisplay_ml/models.py | Passes preview_rows from model_configs to flatten functions during model application |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve stereo reconstruction by adding the geometrical feature img_angres.
Change clipping min for size to '1' (applicable for small images in SSTs).
Add preview_rows as command line parameter to allow flexible printout for debugging.