Skip to content

Add img-angres as feature#51

Merged
GernotMaier merged 5 commits intomainfrom
v1.1-imgangres
Feb 19, 2026
Merged

Add img-angres as feature#51
GernotMaier merged 5 commits intomainfrom
v1.1-imgangres

Conversation

@GernotMaier
Copy link
Copy Markdown
Member

Improve stereo reconstruction by adding the geometrical feature img_angres.
Change clipping min for size to '1' (applicable for small images in SSTs).
Add preview_rows as command line parameter to allow flexible printout for debugging.

@GernotMaier GernotMaier requested a review from Copilot February 18, 2026 14:03
@GernotMaier GernotMaier marked this pull request as ready for review February 18, 2026 14:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances stereo reconstruction in eventdisplay-ML by adding a new geometric feature (img2_ang - image angular resolution), adjusting size clipping for SST telescope support, and adding a configurable preview logging parameter for debugging.

Changes:

  • Adds img2_ang as a new feature for stereo reconstruction to improve direction/energy estimation
  • Changes minimum size clipping from 10 to 1 photoelectrons to support Small Size Telescopes (SSTs) with smaller images
  • Introduces --preview_rows command-line parameter to control the number of events displayed in sorting preview logs

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/eventdisplay_ml/features.py Adds img2_ang to regression feature list and clip intervals (0-360°); changes size min clip from 10 to 1
src/eventdisplay_ml/data_processing.py Adds img2_ang extraction in extra_columns(); threads preview_rows parameter through flattening functions; improves logging format to %-style
src/eventdisplay_ml/config.py Adds --preview_rows CLI argument with default=20 to training and application configs
src/eventdisplay_ml/models.py Passes preview_rows from model_configs to flatten functions during model application

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@GernotMaier GernotMaier merged commit 27dbfc4 into main Feb 19, 2026
2 checks passed
@GernotMaier GernotMaier deleted the v1.1-imgangres branch February 19, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants