-
-
Notifications
You must be signed in to change notification settings - Fork 94
make verified file paths shorter #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
Test Results 51 files + 34 51 suites +34 32m 44s ⏱️ + 20m 42s Results for commit 4be8b44. ± Comparison against base commit 20e513c. This pull request removes 9 and adds 19 tests. Note that renamed tests count towards both. |
* Added ability to specify SessionId and ReplyToSessionId for the producer, along with support for ServiceBusSessionProcessor for the consumer * handle unsubscribe for session processor * make verified file paths shorter (#472) * Updated TestContainers for the emulator * Remove duplicate code Co-authored-by: qodo-merge-for-open-source[bot] <189517486+qodo-merge-for-open-source[bot]@users.noreply.github.com> Co-authored-by: alexey-troshkin-xpress <alexey.troshkin@xpress.com.ph> Co-authored-by: Simon Cropp <simon.cropp@gmail.com> Co-authored-by: qodo-merge-for-open-source[bot] <189517486+qodo-merge-for-open-source[bot]@users.noreply.github.com>
Auto-created Ticket
#473
PR Type
Enhancement
Description
Shortened test method names by removing redundant "AggregateContractToCommand" prefix
Simplified test names to focus on core functionality being tested
Added
IgnoreParameters()to verification call for more flexible test assertionsDiagram Walkthrough
File Walkthrough
AggregateCommandsTests.cs
Simplify test names and enhance verificationsrc/Extensions/test/Eventuous.Tests.Extensions.AspNetCore/AggregateCommandsTests.cs
prefix, keeping only the essential parts (e.g.,
MapAggregateContractToCommandExplicitly→MapContractExplicitly).IgnoreParameters()call to theVerifyJson()assertion in theExecutemethod for more flexible test verification