fix: remove redundant code in memcell extraction#59
Merged
cyfyifanchen merged 1 commit intoFeb 11, 2026
Conversation
- Remove duplicate summary_text assignment in conv_memcell_extractor.py - Remove redundant cluster state file exports in stage1_memcells_extraction.py since cluster_storage.save_cluster_state already handles saving both cluster_state and cluster_map internally Co-Authored-By: Claude <noreply@anthropic.com>
wangmax2011
pushed a commit
to wangmax2011/EverMemOS
that referenced
this pull request
Feb 27, 2026
- Remove duplicate summary_text assignment in conv_memcell_extractor.py - Remove redundant cluster state file exports in stage1_memcells_extraction.py since cluster_storage.save_cluster_state already handles saving both cluster_state and cluster_map internally Co-authored-by: root <root@nlu-guishangtong-sbajo4-0.nlu-guishangtong-sbajo4.lizr-a.svc.dev00-bcebj.local> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two redundant code issues in the memcell extraction pipeline:
Duplicate summary_text assignment in conv_memcell_extractor.py
summary_textassignment on lines 514-516Redundant cluster state file exports in stage1_memcells_extraction.py
cluster_storage.save_cluster_state()method already handles saving bothcluster_stateandcluster_mapinternallyInMemoryClusterStorageChanges Made
Modified Files:
src/memory_layer/memcell_extractor/conv_memcell_extractor.py: Removed duplicate summary_text assignmentevaluation/src/adapters/evermemos/stage1_memcells_extraction.py: Removed redundant cluster state file exportsImpact:
Testing
Notes
These changes improve code quality by removing unnecessary duplication and leveraging existing storage abstractions. The
cluster_storage.save_cluster_state()method is designed to save all necessary cluster-related files, making manual exports redundant.