add a LevelData cache to MapData.Get to increase its performance#466
Merged
Conversation
Member
|
Is there a reason patch_Session couldn't inherit from Session? That would make it unnecessary to reintroduce the Level field. |
Member
Author
|
good question. i will look into it |
Member
|
perhaps replace the getter directly like this |
Signed-off-by: Microlith57 <microlith57@gmail.com>
Signed-off-by: Microlith57 <microlith57@gmail.com>
Member
|
since you have improved mapData.Get, I think there's no need to cache session.LevelData |
Signed-off-by: Microlith57 <microlith57@gmail.com>
Member
Author
|
@DemoJameson done! |
Signed-off-by: Microlith57 <microlith57@gmail.com>
bigkahuna443
reviewed
Jul 8, 2022
bigkahuna443
reviewed
Jul 8, 2022
Contributor
|
Can you edit the PR title to more accurately describe the changes since it got revised? |
microlith57
changed the title
Session.LevelData property for performanceMapData.Get to increase its performance
Signed-off-by: Microlith57 <microlith57@gmail.com>
DemoJameson
approved these changes
Jul 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re. #465