Skip to content

Conversation

@maddie480
Copy link
Member

This is needed for the beginner "heart side". Rue's part uses Remove Light Sources Trigger, but light sources need to be turned back on after passing it.

This is ... pretty much a refactor of the trigger D:

  • instead of using a session flag, the trigger uses mod session
  • instead of handling level exit to turn on/off hooks, the trigger checks mod session. The hooks are made to just "pass through to vanilla" when light sources are not disabled.
  • instead of making bloom invisible and removing lights, the alpha of bloom/light points is multiplied by a float that fades to 0 when light sources are disabled, 1 when they are enabled.

@0x0ade 0x0ade requested a review from Cruor March 29, 2020 15:38
Copy link
Contributor

@Cruor Cruor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@maddie480 maddie480 merged commit 4aab062 into master Mar 30, 2020
@maddie480 maddie480 deleted the restore_light_sources_trigger branch March 30, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants