Skip to content

Variable Crumble Block: fix the 'texture' attribute + add 'respawn time' attribute #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maddie480 merged 1 commit into from
Jun 23, 2020
Merged

Variable Crumble Block: fix the 'texture' attribute + add 'respawn time' attribute #192

maddie480 merged 1 commit into from
Jun 23, 2020

Conversation

@maddie480
Copy link
Member

@maddie480 maddie480 commented Jun 21, 2020

  • The "texture" attribute was not applied at all. I checked all collab maps and changed the "cliffside" crumble blocks to "default" ones so that their look does not change. Only 1 map was impacted (Tortoise's) and the author agreed with this.
  • Added a respawnTimer attribute, so that a dependency on Max Helping Hand for that one attribute isn't required.

@0x0ade 0x0ade requested a review from Cruor June 22, 2020 14:15
Cruor
Cruor approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@Cruor Cruor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@maddie480 maddie480 merged commit 5191cd1 into master Jun 23, 2020
@maddie480 maddie480 deleted the variable_crumble_block_respawn_time branch June 23, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x0ade 0x0ade 0x0ade approved these changes

@Cruor Cruor Cruor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maddie480 @0x0ade @Cruor