Add bubble columns #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x0ade
requested changes
Jan 21, 2020
Entities/BubblePushField.cs
Outdated
| else | ||
| WindMovers.Add(mover, 0f); | ||
| } else { | ||
| if(WindMovers.ContainsKey(mover)) { |
Member
There was a problem hiding this comment.
Suggested change
| if(WindMovers.ContainsKey(mover)) { | |
| if (WindMovers.ContainsKey(mover)) { |
Entities/BubblePushField.cs
Outdated
| class BubblePushField : Entity { | ||
| public new int Width; | ||
|
|
||
| public new int Height; |
Entities/BubblePushField.cs
Outdated
| Position = BubbleField.Position; | ||
|
|
||
| Rand = BubbleField.Rand; | ||
| Texture = GFX.Game["particles/SpringCollab2020/bubble_" + new string[] { "a", "b" }[Rand.Next(0, 1)]]; |
Member
There was a problem hiding this comment.
Array should be stored in a static readonly field.
Cruor
requested changes
Jan 22, 2020
Contributor
Cruor
left a comment
Cruor
left a comment
There was a problem hiding this comment.
Ahorn plugin looks good to me functionality wise.
Please fix the mixed usage of spaces and tabs for indentation though.
Fix inconsistent usage of space/tabs in Ahorn plugin Small code tweaks in C# portion
Contributor
Author
0x0ade
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bubble columns. They look like water (with moving bubble particles), and can push you in any direction with a configurable strength.
Requested by me