Sideways jumpthrus #57
Conversation
Entities/SidewaysJumpThru.cs
Outdated
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
What's up with the whitespace here?
There was a problem hiding this comment.
That was to separate hook code from the entity code 😅 I think I should drop a comment in here instead.
Cruor
left a comment
Cruor
left a comment
There was a problem hiding this comment.
allowLeftToRight sounds a bit strange to me, makes it sound like it is normally fully solid, but you can set the flag to go through it from left -> right. Doesn't the base game just do left or right for these kinds of things?
Looks good to me otherwise though.
|
I'll double-check what the base game does for orientation settings. Would "right" mean the upper side of the jumpthru is on the right side, so you can go left to right? 🤔 |
|
Attribute renamed on the Ahorn plugin side, comment added instead of that awkward gap on the C# side. |
Closes #20.
This time, I didn't make it extend JumpThru, since those have little in common (... the orientation to begin with: jump thrus extend on their width).
Most of how it works is an IL patch applied on multiple methods, that adds collide checks against sideways jumpthrus everywhere the game checks for solids. This way, Madeline can climb on and walljump off sideways jumpthrus.
(Note to self: the Julia part seems to need a tab to space pass.)