fix(ce-commit-push-pr): append PR body so zsh noclobber can't blank it#1008
Merged
Conversation
mktemp creates the temp file empty, then `cat >` redirected onto the existing file. Under zsh `setopt noclobber`, `>` to an existing file is refused, the heredoc is discarded, and gh publishes an empty PR body while still exiting 0. Switch to `cat >>` (append), which is equivalent for the already-empty file and is independent of clobber settings. Fixes #1003
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Under zsh with
noclobberset, this skill's recommended snippet silently published an empty PR body —ghstill exited 0 and returned a valid URL, so the failure was invisible unless you re-read the PR.mktempcreates the temp file empty, thencat >redirected onto the now-existing file;noclobberrefuses>to an existing file, discarding the heredoc. Switching tocat >>(append) writes the body regardless of clobber settings — equivalent for the already-empty file, and identical in bash and zsh.This is the exact silent-empty-body failure the section's own warning (line 119) exists to prevent.
Fixes #1003