fix(review): escape literal pipes in finding table cells#779
Merged
Conversation
Findings whose titles or descriptions contained a literal `|` (e.g. cache key delimiter examples like `userName + " |" + groups`, regex alternations, logical-OR operators) corrupted the markdown table -- unescaped pipes were parsed as column separators, splitting content across the `Reviewer`, `Confidence`, and `Route`/`Tier` columns. Add an escape rule to both review-output templates so the synthesis LLM writes literal pipes as `\|` inside table cells. The rule lives prominently next to the existing pipe-table directive at the top of each template, plus as a parallel Formatting Rules bullet in ce-code-review where the issue reporter expected to find it. The synthesis path is purely prose-driven (`@`-include from SKILL.md), so a missing rule = missing behavior; no code or test surface to change. Fixes #761 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merged
davidalee
added a commit
to davidalee/compound-engineering-plugin
that referenced
this pull request
May 6, 2026
PR EveryInc#779 added pipe-escaping guidance to the stable copy of references/review-output-template.md but the beta copy didn't pick it up through the main->branch merge. The shared-reference parity test was failing because of the drift; copying stable's content over beta's restores byte parity and unblocks CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code-review findings whose titles or descriptions contained a literal
|(cache-key delimiter examples, regex alternations, logical-OR operators) corrupted the synthesized findings table — unescaped pipes were parsed as column separators, splitting content across theReviewer,Confidence, andRoutecolumns. The findings JSON was correct upstream; the bug lived purely in the prose-driven serialization step.Adds an escape rule to both
ce-code-reviewandce-doc-reviewreview-output-template.mdfiles: literal|inside a table cell must be written as\|. The rule sits next to the existing pipe-table directive at the top of each template, plus as a parallel bullet ince-code-review'sFormatting Rulessection where the issue reporter expected to find it. The same gap was latent ince-doc-review's template, so both ship together.Synthesis is purely LLM-prose-driven from these
@-included templates, so there is no unit-test surface; manual verification is to run/ce-code-reviewon a diff containing a|-bearing finding and confirm the table renders intact.Fixes #761