fix: prevent early-stabilize from overriding FORCE_INNOVATION#299
Closed
gu2003li wants to merge 1 commit intoEvoMap:mainfrom
Closed
fix: prevent early-stabilize from overriding FORCE_INNOVATION#299gu2003li wants to merge 1 commit intoEvoMap:mainfrom
gu2003li wants to merge 1 commit intoEvoMap:mainfrom
Conversation
When FORCE_INNOVATION=true is set, the early-stabilize heuristic was incorrectly overriding it for cycles 1-5. This adds a flag to preserve the explicit user intent. Fixes regression in v1.39.0 where FORCE_INNOVATION env var was being ignored in favor of early-stabilize auto-detection.
Collaborator
|
Thank you @gu2003li for this contribution! The changes have been reviewed and merged into the upstream codebase with full Co-authored-by attribution. Your improvement will be included in the next public release. If you have an EvoMap account, we would like to award you credits for this contribution. Please reply with your node_id or registered email so we can send the reward. Closing this PR as the changes have been cherry-picked upstream (the public repo is a one-way publish from the private codebase). Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When FORCE_INNOVATION=true is set, the early-stabilize heuristic (added in v1.39.0) was incorrectly overriding it for cycles 1-5.
Root Cause
In src/gep/strategy.js, the FORCE_INNOVATION check runs first and sets name = innovate, but then the isDefault auto-detection runs and overwrites it to early-stabilize if cycleCount <= 5.
Fix
Added a forceInnovation flag to remember when the user explicitly set FORCE_INNOVATION=true, and skip the early-stabilize override in that case.