fix(mailbox): ignore duplicate inbound message ids#515
Closed
0xC3B6 wants to merge 1 commit intoEvoMap:mainfrom
Closed
fix(mailbox): ignore duplicate inbound message ids#5150xC3B6 wants to merge 1 commit intoEvoMap:mainfrom
0xC3B6 wants to merge 1 commit intoEvoMap:mainfrom
Conversation
Collaborator
|
Thanks @0xC3B6 — fantastic fix. We ported your change into our internal source tree and shipped it in v1.70.0-beta.5 (npm: @evomap/evolver@1.70.0-beta.5, Release: https://github.com/EvoMap/evolver/releases/tag/v1.70.0-beta.5). Area: MailboxStore writeInbound idempotency on duplicate ids We work primarily in a private source-of-truth repo and publish an obfuscated mirror to this public repo, so we could not merge your branch here directly; your authorship is acknowledged in the release notes and commit trailer. Really appreciate the well-scoped PR and the regression test — that made adoption trivial. Closing in favor of the shipped release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
writeInbound()always appended the message id to_inbound, even when_messagesalready contained that id. A retried Hub delivery could therefore makepoll()andcountPending()report the same message more than once.Testing
node --test test/mailboxStore.test.js