Skip to content

fix: copy _memoryFiltering.js in setup-hooks (#547) #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mvanhorn wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −3
Open

fix: copy _memoryFiltering.js in setup-hooks (#547) #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/adapters/hookAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ function copyHookScripts(destDir, evolverRoot) {
// with MODULE_NOT_FOUND at runtime. Caught in PR #94 review.
const scripts = [
'_runtimePaths.js',
'_memoryFiltering.js',
'evolver-session-start.js',
'evolver-signal-detect.js',
'evolver-session-end.js',
Expand Down Expand Up @@ -237,6 +238,7 @@ function removeEvolverHooks(filePath, { markerKey = '_evolver_managed' } = {}) {
function removeHookScripts(hooksDir) {
const scripts = [
'_runtimePaths.js',
'_memoryFiltering.js',
'evolver-session-start.js',
'evolver-signal-detect.js',
'evolver-session-end.js',
Expand Down
19 changes: 16 additions & 3 deletions test/adapters.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,9 @@ describe('hookAdapter', () => {
const destDir = path.join(tmp, 'hooks');
const evolverRoot = path.resolve(__dirname, '..');
const copied = hookAdapter.copyHookScripts(destDir, path.join(evolverRoot, 'src', 'adapters'));
// 3 hook entry points + _runtimePaths helper required by two of them.
assert.equal(copied.length, 4);
// 3 hook entry points + _runtimePaths and _memoryFiltering helpers
// required by session-start.
assert.equal(copied.length, 5);
for (const f of copied) {
assert.ok(fs.existsSync(f));
}
Expand All @@ -168,6 +169,17 @@ describe('hookAdapter', () => {
`copied evolver-session-start.js must run without error. stderr=${result.stderr}`);
} finally { cleanup(tmp); }
});

it('includes _memoryFiltering.js so copied session-start can require it (#547)', () => {
const tmp = makeTmpDir();
try {
const destDir = path.join(tmp, 'hooks');
const evolverRoot = path.resolve(__dirname, '..');
hookAdapter.copyHookScripts(destDir, path.join(evolverRoot, 'src', 'adapters'));
assert.ok(fs.existsSync(path.join(destDir, '_memoryFiltering.js')),
'_memoryFiltering.js must ship alongside session-start or it crashes with MODULE_NOT_FOUND');
} finally { cleanup(tmp); }
});
});

describe('removeHookScripts', () => {
Expand All @@ -177,12 +189,13 @@ describe('hookAdapter', () => {
const hooksDir = path.join(tmp, 'hooks');
fs.mkdirSync(hooksDir, { recursive: true });
fs.writeFileSync(path.join(hooksDir, '_runtimePaths.js'), '');
fs.writeFileSync(path.join(hooksDir, '_memoryFiltering.js'), '');
fs.writeFileSync(path.join(hooksDir, 'evolver-session-start.js'), '');
fs.writeFileSync(path.join(hooksDir, 'evolver-signal-detect.js'), '');
fs.writeFileSync(path.join(hooksDir, 'evolver-session-end.js'), '');
fs.writeFileSync(path.join(hooksDir, 'user-custom.js'), '');
const removed = hookAdapter.removeHookScripts(hooksDir);
assert.equal(removed, 4);
assert.equal(removed, 5);
assert.ok(fs.existsSync(path.join(hooksDir, 'user-custom.js')));
} finally { cleanup(tmp); }
});
Expand Down