Skip to content

fix(instance.controller): emit remove.instance even when logout fails (zombie cleanup) #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inovacaoecrescimento wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −1
Open

fix(instance.controller): emit remove.instance even when logout fails (zombie cleanup) #2520

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e4f4a7
fix(instance.controller): emit remove.instance even when logout fails
Apr 27, 2026
93b9081
review: address Sourcery feedback — neutral language + log error object
Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/api/controllers/instance.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,21 @@ export class InstanceController {
if (this.configService.get<Chatwoot>('CHATWOOT').ENABLED) waInstances?.clearCacheChatwoot();

if (instance.state === 'connecting' || instance.state === 'open') {
await this.logout({ instanceName });
try {
await this.logout({ instanceName });
} catch (error) {
// logout can throw "Connection Closed" when the underlying Baileys
// socket is already dead but waInstances[name] still exists. We
// must continue to the remove.instance emit below — that is the
// only path that purges the in-memory entry and runs cleaningUp().
// Without this catch, the stale entry persists until the entire
// process restarts.
this.logger.warn({
message: 'logout failed during deleteInstance — proceeding with cleanup',
instanceName,
error,
});
}
}

try {
Expand Down