Skip to content

Trouble was added to the project.#85

Merged
Pakrohk merged 4 commits into
mainfrom
Develop
Mar 2, 2023
Merged

Trouble was added to the project.#85
Pakrohk merged 4 commits into
mainfrom
Develop

Conversation

@Pakrohk
Copy link
Copy Markdown
Contributor

@Pakrohk Pakrohk commented Feb 28, 2023

No description provided.

@Pakrohk Pakrohk requested review from ARS101, Grphq1 and H-cyber February 28, 2023 23:01
@Pakrohk Pakrohk self-assigned this Feb 28, 2023
@Pakrohk Pakrohk added the enhancement New feature or request label Feb 28, 2023
@Pakrohk Pakrohk added this to the v2.4.0 milestone Feb 28, 2023
@Pakrohk Pakrohk linked an issue Feb 28, 2023 that may be closed by this pull request
Copy link
Copy Markdown
Collaborator

@ARS101 ARS101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems good.

Copy link
Copy Markdown
Collaborator

@Grphq1 Grphq1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have used require twice in trouble.lua file

lua/packages/bindings/trouble.lua -> line 2

local hotkeys = require("packages.bindings.trouble")

lua/packages/bindings/trouble.lua -> line 31

require("packages.bindings.trouble")

@Pakrohk
Copy link
Copy Markdown
Contributor Author

Pakrohk commented Mar 1, 2023

You have used require twice in trouble.lua file

Yes, I also once made an application from it so that I could call a part of the file only in one place.

padding = true, -- add an extra new line on top of the list
hotkeys.action_keys,
indent_lines = true, -- add an indent guide below the fold icons

But normal keys can't be introduced to config with this method, so I had to call all the keys file again, the better way is to make a fallback.
But I still don't have a specific idea for it.

@Pakrohk Pakrohk merged commit a7fb91b into main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trouble

3 participants