Skip to content

Translate Chinese comments to English in eval_encoder directory#35

Merged
anxiangsir merged 2 commits intomainfrom
copilot/translate-chinese-comments-to-english
Dec 29, 2025
Merged

Translate Chinese comments to English in eval_encoder directory#35
anxiangsir merged 2 commits intomainfrom
copilot/translate-chinese-comments-to-english

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 29, 2025

Translates all Chinese comments to English in the eval_encoder directory for better international readability.

Changes

  • eval_encoder/attentive_probe.py: Translated ~40 lines of Chinese comments including:
    • Function docstrings (interpolate_frame_indices, get_feature, video_to_images)
    • Parameter descriptions and inline comments
    • Data processing and evaluation comments

Example:

# Before
# ===> 新增:目标帧数参数 <===
# 将帧索引从原始视频帧数插值到目标帧数

# After  
# ===> New: target frame number parameter <===
# Interpolate frame indices from original video frame count to target frame count

attentive_probe_codec.py and shell scripts already had English comments—no changes needed.

Original prompt

将所有的

https://github.com/EvolvingLMMs-Lab/OneVision-Encoder/tree/main/eval_encoder

的中文注释改为英文注释


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: anxiangsir <31175974+anxiangsir@users.noreply.github.com>
Copilot AI changed the title [WIP] Translate Chinese comments to English in eval_encoder Translate Chinese comments to English in eval_encoder directory Dec 29, 2025
Copilot AI requested a review from anxiangsir December 29, 2025 14:27
@anxiangsir anxiangsir marked this pull request as ready for review December 29, 2025 14:28
Copilot AI review requested due to automatic review settings December 29, 2025 14:28
@anxiangsir anxiangsir merged commit c5b78b6 into main Dec 29, 2025
2 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR translates all Chinese comments to English in the eval_encoder/attentive_probe.py file to improve international code readability. The translations cover function docstrings, parameter descriptions, inline comments, and data processing notes.

Key changes:

  • Translated approximately 40 lines of Chinese comments to English
  • Improved documentation clarity for international developers
  • Removed corrupted text from one comment line

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@anxiangsir anxiangsir deleted the copilot/translate-chinese-comments-to-english branch December 30, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants