Improve SIDHistory Cleanup by removing not working code#27
Merged
PrzemyslawKlys merged 2 commits intomasterfrom Apr 1, 2025
Merged
Improve SIDHistory Cleanup by removing not working code#27PrzemyslawKlys merged 2 commits intomasterfrom
PrzemyslawKlys merged 2 commits intomasterfrom
Conversation
* Refactored the SID removal logic to process individual SIDs instead of all at once. * Improved error handling and logging for SID removal actions. * Enhanced user feedback for both successful and failed SID removals.
* Incremented the module version to reflect recent changes. * Ensures compatibility with the latest features and fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a version update and a significant refactor to the
Remove-ADSIDHistoryfunction in theCleanupMonstermodule. The refactor simplifies the logic by removing the handling of processing all SIDs at once.Version update:
CleanupMonster.psd1: UpdatedModuleVersionfrom '3.1.0' to '3.1.1'.Refactor:
Remove-ADSIDHistory.ps1: Removed the code block that processed all SIDs for an object at once (wasn't working), including the associatedShouldProcesschecks and error handling. The function now only processes individual SIDs. [1] [2]