Unify navigation and 404 behavior with pipeline audit guardrails#75
Unify navigation and 404 behavior with pipeline audit guardrails#75PrzemyslawKlys merged 5 commits intomasterfrom
Conversation
|
Claude finished @PrzemyslawKlys's task —— View job PR Review: Unify navigation and 404 behavior with pipeline audit guardrailsReview Tasks:
🔴 Critical Issue: GitHub Pages 404 CompatibilityProblem: The markdown 404 approach ( Impact: Broken 404 handling on production - users will see GitHub's default 404 instead of the branded experience. Evidence:
Recommendation: The build validation in ✅ Code Quality AssessmentMainLayout.razor (Lines 180, 192)Excellent implementation:
Build Script Enhancement (Lines 93-103)Well-designed validation:
Pipeline ConfigurationSmart improvements: "clean": true // ✅ Prevents stale playground artifacts
"ignoreNav": "sitemap/**,playground/index.html,playground/404.html" // ✅ More precise exclusions
"navRequiredLinks": "/" // ✅ Enforces Home link presence in audits
"renderedEnsureInstalled": false // ✅ Disables Playwright auto-install🟡 Minor ConcernsPerformance
Security
Test Coverage
📋 Detailed Technical ReviewMainLayout.razor Analysis// Line 180 - Primary nav addition
new NavLink("/", "Home"),
// Line 192 - Footer nav addition
new NavLink("/", "Home"),
404.md Structureslug: 404 # ⚠️ Combined with TrailingSlash creates /404/
collection: pages # ✅ Correct collection
layout: home # ✅ Consistent layout
meta.breadcrumbs: false # ✅ Appropriate for error pagesBuild Validation Logic$notFoundPage = Join-Path $SiteRoot '404.html'
if (-not (Test-Path -LiteralPath $notFoundPage -PathType Leaf)) {
throw "Build validation failed: expected '$notFoundPage' for GitHub Pages 404 handling."
}Excellent defensive programming - this validation would catch the 404 routing issue. 🎯 Recommendations
✅ SummaryStrong PR overall with excellent code quality, defensive validation, and smart pipeline improvements. The only concern is the potential GitHub Pages 404 compatibility issue flagged by the automated review, though the build validation suggests this may be handled correctly by the build system. Approval recommendation: Verify the 404.html generation works as expected, then approve. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a601090de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR unifies navigation behavior across the static site and Blazor playground application while improving build pipeline hygiene and audit controls.
Changes:
- Adds missing "Home" link to Blazor app navigation (header and footer)
- Migrates 404 page from standalone static HTML to markdown content using the site's templating system
- Enables clean builds for the playground to prevent stale artifacts
- Tightens audit navigation checks by requiring Home links and narrowing the ignore list to specific shell files
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Website/static/404.html | Removed standalone static 404 page (196 lines deleted) |
| Website/content/pages/404.md | Added new markdown-based 404 page using the home layout for consistency |
| Website/pipeline.json | Added clean flag to dotnet-publish, tightened ignoreNav to specific files, added navRequiredLinks, disabled Playwright auto-install |
| CodeGlyphX.Website/Layout/MainLayout.razor | Added Home link ("/") to both primary navigation and footer Product section |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 59.74% 59.75%
=======================================
Files 448 448
Lines 57814 57814
Branches 16563 16563
=======================================
+ Hits 34543 34545 +2
+ Misses 17566 17565 -1
+ Partials 5705 5704 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Applied the 404-related bot feedback in commit
This ensures GitHub Pages compatibility while still using unified markdown/layout generation. |
|
Follow-up cleanup in commit
Reason: CI website build checks out |
|
Summary
avRequiredLinks: /)
Validation