feat(automation): ✨ add hosted-session diagnostics and safer ui test gates#160
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84c1748ba0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Assert.Inconclusive("Test requires Windows"); | ||
| } | ||
| TestHelper.RequireOwnedWindowUiTests(); | ||
| TestHelper.RequireForegroundWindowUiTests(); |
There was a problem hiding this comment.
Restore owned-window gate before running activation harness test
Switching this test from RequireOwnedWindowUiTests() to RequireForegroundWindowUiTests() drops the RUN_OWNED_WINDOW_UI_TESTS safeguard (and its interactive-desktop check), so the repo-owned WinForms harness can now run whenever foreground gates are enabled even if owned-window tests were intentionally left disabled. That undermines the safety split introduced in this change and can unexpectedly open/activate harness windows in environments that set foreground flags but do not opt into owned-window UI tests.
Useful? React with 👍 / 👎.
Summary
Verification
PowerShellControlMutationTests|FullyQualifiedNamePowerShellWindowMutationTests|FullyQualifiedName~PowerShellHostedSessionDiagnosticTests"DiagnosticCommandOutputTests|FullyQualifiedNameHostedSessionDiagnosticReaderCliTests|FullyQualifiedNameCliApplicationTests|FullyQualifiedNameHelpTextTests"Notes