fix(review): unresolved DesktopManager follow-ups#165
Merged
PrzemyslawKlys merged 2 commits intov2-speedygonzalesfrom Mar 31, 2026
Merged
fix(review): unresolved DesktopManager follow-ups#165PrzemyslawKlys merged 2 commits intov2-speedygonzalesfrom
PrzemyslawKlys merged 2 commits intov2-speedygonzalesfrom
Conversation
- return null for nullable observation APIs when no window matches - parse decimal colors before hexadecimal fallbacks in CLI parsing - reject allSessions mixed with selectors in MCP keep-alive stop - add regression tests for observation, parser, and MCP catalog handling
- guard CLI-only test files so the multi-target test project still compiles on net472 - verify with Release solution build to match the failing GitHub Actions job
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation