Skip to content

Simplify project build and stabilize wallpaper history tests#167

Merged
PrzemyslawKlys merged 1 commit intov2-speedygonzalesfrom
feature/wallpaper-history-build-cleanup
Apr 3, 2026
Merged

Simplify project build and stabilize wallpaper history tests#167
PrzemyslawKlys merged 1 commit intov2-speedygonzalesfrom
feature/wallpaper-history-build-cleanup

Conversation

@PrzemyslawKlys
Copy link
Copy Markdown
Member

Summary

  • simplify Build/Build-Project.ps1 so it behaves like the OfficeIMO build wrapper and no longer mixes module and tool publishing concerns
  • make WallpaperHistory re-evaluate DESKTOPMANAGER_HISTORY_PATH on each access instead of caching the first resolved path
  • stabilize WallpaperHistory tests by using isolated temp directories and cleaning them up recursively

Why

PowerBGInfo is moving toward a more standalone packaging story, so DesktopManager build behavior should stay predictable and narrowly scoped. The history-path change also makes the test suite reliable when the environment variable changes during a run.

Validation

  • git diff --check
  • dotnet build Sources\\DesktopManager.sln
  • dotnet test Sources\\DesktopManager.Tests\\DesktopManager.Tests.csproj --no-build --filter WallpaperHistoryTests
  • pwsh -NoLogo -NoProfile -File Build\\Build-Project.ps1 -Plan:$true -Build:$false -UpdateVersions:$false

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2334a2c89b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Build/Build-Project.ps1
Comment on lines +5 to +6
[Nullable[bool]] $PublishNuget = $false,
[Nullable[bool]] $PublishGitHub = $false,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Do not override publish flags from config

Setting PublishNuget and PublishGitHub to $false by default makes these parameters non-null on every invocation, so the later $null -ne ... checks always pass and Invoke-ProjectBuild is always called with both publish flags forced to false. This silently breaks any workflow that relies on a config file (-ConfigPath) where PublishNuget/PublishGitHub are true, because those config values can no longer take effect unless callers explicitly re-pass :$true on the command line.

Useful? React with 👍 / 👎.

@PrzemyslawKlys PrzemyslawKlys merged commit 4a49d17 into v2-speedygonzales Apr 3, 2026
7 checks passed
@PrzemyslawKlys PrzemyslawKlys deleted the feature/wallpaper-history-build-cleanup branch April 3, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant