Skip to content

Fix CaptureRegion bounds validation#85

Merged
PrzemyslawKlys merged 1 commit intov2-speedygonzalesfrom
validate-region-bounds-in-captureregion-method
Jul 8, 2025
Merged

Fix CaptureRegion bounds validation#85
PrzemyslawKlys merged 1 commit intov2-speedygonzalesfrom
validate-region-bounds-in-captureregion-method

Conversation

@PrzemyslawKlys
Copy link
Copy Markdown
Member

Summary

  • guard ScreenshotService.CaptureRegion against coordinates outside virtual screen
  • compute virtual screen bounds on non-Windows frameworks using GetSystemMetrics
  • validate out-of-bounds behavior in ScreenshotServiceTests
  • enable Windows Forms for .NET Framework builds to access SystemInformation

Testing

  • dotnet build Sources/DesktopManager/DesktopManager.csproj --no-restore
  • dotnet build Sources/DesktopManager.Tests/DesktopManager.Tests.csproj --no-restore
  • dotnet test Sources/DesktopManager.Tests/DesktopManager.Tests.csproj --no-build -f net8.0 (fails: COM not supported)

https://chatgpt.com/codex/tasks/task_e_686ce53a5f4c832e8e990dff11a6ec55

@PrzemyslawKlys PrzemyslawKlys merged commit 1092e4e into v2-speedygonzales Jul 8, 2025
7 checks passed
@PrzemyslawKlys PrzemyslawKlys deleted the validate-region-bounds-in-captureregion-method branch July 8, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant